2.4.6-headings-and-labels-descriptive-icons #4147
Open
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Wording changes to explanation of descriptive icon (different contexts affext interpretation).
minor edit.
minor wording changes
scottaohara
reviewed
Nov 21, 2024
Changing "loupe" to "magnifying glass"
scottaohara
reviewed
Nov 21, 2024
| @@ -30,6 +30,9 @@ <h2>Intent of Headings and Labels</h2> | |||
| <p>Labels and headings do not need to be lengthy. A word, or even a single character, | |||
| may suffice if it provides an appropriate cue to finding and navigating content. | |||
| </p> | |||
| <p>Labels of form controls are usually text-based. In some cases, images can serve as descriptive label without additional text. In these cases, authors should ensure that the image and its use as label in a particular context can be considered conventional and widely understood. | |||
There was a problem hiding this comment.
making 'label' plural to match the preceding plural 'images'.
swapped out 'should' with 'would need to' to avoid using "should" in an informative doc.
Suggested change
| <p>Labels of form controls are usually text-based. In some cases, images can serve as descriptive label without additional text. In these cases, authors should ensure that the image and its use as label in a particular context can be considered conventional and widely understood. | |
| <p>Labels of form controls are usually text-based. In some cases, images can serve as descriptive labels without additional text. In these cases, authors would need to ensure that the image and its use as label in a particular context can be considered conventional and widely understood. |
scottaohara
reviewed
Nov 21, 2024
| @@ -30,6 +30,9 @@ <h2>Intent of Headings and Labels</h2> | |||
| <p>Labels and headings do not need to be lengthy. A word, or even a single character, | |||
| may suffice if it provides an appropriate cue to finding and navigating content. | |||
| </p> | |||
| <p>Labels of form controls are usually text-based. In some cases, images can serve as descriptive label without additional text. In these cases, authors should ensure that the image and its use as label in a particular context can be considered conventional and widely understood. | |||
| Note that the same icon can be interpreted differently in different contexts and still be considered descriptive in that context. For example, placed after a search field, a magnifying glass icon is commonly interpreted as triggering a search. | |||
| Placed on an image, a magnifying glass icon is commonly interpreted as opening a magnified version of the image (or zooming into that image).</p> | |||
There was a problem hiding this comment.
some suggested text to expand on this
Suggested change
| Placed on an image, a magnifying glass icon is commonly interpreted as opening a magnified version of the image (or zooming into that image).</p> | |
| Placed on or near another image, a loupe or magnify glass icon is commonly interpreted as a means to view a magnified version of the image (for instance, acting as a mechanism to zoom into the image, or opening a full-sized image in a new window).</p> |
scottaohara
reviewed
Nov 21, 2024
| @@ -30,6 +30,9 @@ <h2>Intent of Headings and Labels</h2> | |||
| <p>Labels and headings do not need to be lengthy. A word, or even a single character, | |||
| may suffice if it provides an appropriate cue to finding and navigating content. | |||
| </p> | |||
| <p>Labels of form controls are usually text-based. In some cases, images can serve as descriptive label without additional text. In these cases, authors should ensure that the image and its use as label in a particular context can be considered conventional and widely understood. | |||
| Note that the same icon can be interpreted differently in different contexts and still be considered descriptive in that context. For example, placed after a search field, a magnifying glass icon is commonly interpreted as triggering a search. | |||
There was a problem hiding this comment.
Some suggested text for you to consider:
- swapped out the first instance of "icon" with "image", as previously "image" was the term being used, and prior to introducing the example, changing to "icon" seemed awkward.
- Split the first sentence into two, and carried over the "conventional and widely understood" caveat from the previous paragraph to explain why it can be still descriptive in different contexts.
- changed "when placed after" to "accompanying a" since the former was narrowly scoped and not representative of how all instances of search fields might be designed.
- similarly changed 'triggering' to the changed text because sometimes a search icon is merely a label, and sometimes it also acts as a button, but it always is a means to identifying the search widget.
Suggested change
| Note that the same icon can be interpreted differently in different contexts and still be considered descriptive in that context. For example, placed after a search field, a magnifying glass icon is commonly interpreted as triggering a search. | |
| Note that the same image can be interpreted differently in different contexts. However, it can still be considered descriptive if its use is commonly understood in each context. For example, when accompanying a text field, a loupe or magnifying glass icon is commonly interpreted as indicating the field is for entering and submitting a search query. |
|
Sounds all very reasonable. Do you want to create a PR on my PR or do you want me to implement those changes? |
|
@detlevhfischer i provided them as suggestions so that if you agree with them, you can just commit them into your existing PR via GitHub's "commit suggestion" button that follows each of my proposed changes. I would rather you be the one to commit these, as personally am against the idea of someone editing/committing to someone else's PR without explicit permission :) |
I gave you permission, I suggested it :) - but no problem, I think your suggestions are good and I will work them in myself. |
just to reiterate, if it's not obvious: all you need to do is press the "Commit suggestion" for each here in github, no need to manually try to rework your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed addition to the 2.4.6 Understanding text that states that conventional icons can in some cases serve as descriptive label of form controls. Included is an example of a conventional icon (loupe for search).
See rendered version of the revised 2.4.6 Understanding text