Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update F2.html #4128

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update F2.html #4128

wants to merge 8 commits into from

Conversation

mbgower
Copy link
Contributor

@mbgower mbgower commented Nov 1, 2024

  • rephrased the introduction to include mention of assistive technology
  • removed example 3
  • updated outcome logic of checks 1 and 2
  • added a third condition to check 2

Resolves #4109

- removed example 3
- updated outcome logic of checks 1 and 2
- added a third condition to check 2
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit c6bb6d0
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/6737775fb31ac6000830aff0
😎 Deploy Preview https://deploy-preview-4128--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

techniques/failures/F2.html Outdated Show resolved Hide resolved
mbgower and others added 2 commits November 1, 2024 06:36
modified the introduction to include the third check in test 2
@mbgower mbgower self-assigned this Nov 1, 2024
techniques/failures/F2.html Outdated Show resolved Hide resolved
techniques/failures/F2.html Outdated Show resolved Hide resolved
@bruce-usab
Copy link
Contributor

Discussed on backlog call 11-1. Concern on call with only having heading examples, since CSS can semantically be used to convey emphasis.

Pulled back expansion of the failure technique to include presentation markup detected by assistive technologies.
@mbgower
Copy link
Contributor Author

mbgower commented Nov 1, 2024

Created a new issue to track unincorporated changes #4132

techniques/failures/F2.html Outdated Show resolved Hide resolved
techniques/failures/F2.html Outdated Show resolved Hide resolved
@mbgower
Copy link
Contributor Author

mbgower commented Nov 15, 2024

Once the other non-structural changes have been added in the other Issue, the wording of the first check can be adjusted to something like the a prior commit

@detlevhfischer
Copy link
Contributor

detlevhfischer commented Nov 21, 2024

Test: The sentence

If condition 2 is true, the failure condition does not apply

seems superfluous and therefore a bit odd (it seems implied in the first part).

But I have more general concerns about this Failure Technique. People will use it to fail content that use things like b and i instead of strong and em so they will let content fail for stuff that is usually not semantically available to screen reader users (unless you explicitly check for styling / emphasis). And there are cases where the author might rightfully claim that b or i were used for stylistic reasons that do not map onto the HTML semantics. Should there be a not limiting of the Failure to cases like headings where the practical issue is clear (or a warning that often inline semantic markup is not honored by AT)?

@mbgower
Copy link
Contributor Author

mbgower commented Nov 22, 2024

Test: The sentence

If condition 2 is true, the failure condition does not apply

seems superfluous and therefore a bit odd (it seems implied in the first part).

The existing language does not actually say what results produce a failure. I agree that the second sentence (which declares what does not fail) is restating the other side of a logic loop. If people feel its removal is unlikely to result in erroneous interpretation, I'm fine to remove. But I don't see it causes a problem being there.

But I have more general concerns about this Failure Technique. People will use it to fail content that use things like b and i instead of strong and em so they will let content fail for stuff that is usually not semantically available to screen reader users (unless you explicitly check for styling / emphasis). And there are cases where the author might rightfully claim that b or i were used for stylistic reasons that do not map onto the HTML semantics. Should there be a not limiting of the Failure to cases like headings where the practical issue is clear (or a warning that often inline semantic markup is not honored by AT)?

As you may see from the discussion, there is general concern with the scope of this failure technique. We are removing with this change example 3 as a first attempt to reduce the problems. There is also another issue open to further this work.
That said, can you provide an example of a situation where bold and italic are used that are not meant to convey meaning that could not be conveyed semantically?

@detlevhfischer
Copy link
Contributor

That said, can you provide an example of a situation where bold and italic are used that are not meant to convey meaning that could not be conveyed semantically?

I think it could be cases where you don't want to put emphasis on a bit of text but differentiate: technical terms, taxanomic terms, etc. Or a title that is not put into quotation marks:

In Edgar Allan Poe's short story A Descent into the Maelström a man recounts how he survived a shipwreck and a whirlpool.

See also https://developer.mozilla.org/en-US/docs/Web/HTML/Element/i

I admit there is a blurry line between i and em...

@bruce-usab
Copy link
Contributor

  1. Discussed on TF call 11/22. MG will work out with Detlev.

@mbgower
Copy link
Contributor Author

mbgower commented Nov 22, 2024

I think it could be cases where you don't want to put emphasis on a bit of text but differentiate: technical terms, taxanomic terms, etc. Or a title that is not put into quotation marks:

In Edgar Allan Poe's short story A Descent into the Maelström a man recounts how he survived a shipwreck and a whirlpool.

But that has a precise meaning. Italics used in such a case are meant to identify the title of a book or work. The appropriate element to use would be the <cite> element, which is normally shown as italics by browsers.


See also https://developer.mozilla.org/en-US/docs/Web/HTML/Element/i

That page also identifies some of these other semantic meanings some of which are also rendered as italicized text:

Be sure the text in question is not actually more appropriately marked up with another element.

  • Use <em> to indicate stress emphasis.
  • Use <strong> to indicate importance, seriousness, or urgency.
  • Use <mark> to indicate relevance.
  • Use <cite> to mark up the name of a work, such as a book, play, or song.
  • Use <dfn> to mark up the defining instance of a term.

I do wonder, given this, if adding "visual" in the test is appropriate, as there is both a contextual and visual meaning being reinforced. Suffice it to say that we will likely be working on changes to this failure technique for awhile. At the moment, the focus is on removing the most problematic example.

@@ -66,15 +48,14 @@ <h3>Using CSS to visually emphasize a phrase or word without conveying that emph
<p>For styled text that conveys information:</p>
<ol>
<li>Check if there is any styled text that conveys structural information.</li>
<li>Check that in addition to styling, the proper semantic structure is used with the text to convey the information.</li>
<li>Check that in addition to styling, the proper semantic structure is used with the text to convey the visual information.</li>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li>Check that in addition to styling, the proper semantic structure is used with the text to convey the visual information.</li>
<li>Check that in addition to styling, the proper semantic structure is used with the text to convey the information.</li>

Copy link
Contributor Author

@mbgower mbgower Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on discussion with Detlev and prior discussions, pulling back the addition of "visual" as that may be unnecessarily confining what kind of information is conveyed (i.e., yes, the citation element puts it in italics, but it is also conveying more than that).

@mraccess77
Copy link

I think it could be cases where you don't want to put emphasis on a bit of text but differentiate: technical terms, taxanomic terms, etc. Or a title that is not put into quotation marks:
In Edgar Allan Poe's short story A Descent into the Maelström a man recounts how he survived a shipwreck and a whirlpool.

But that has a precise meaning. Italics used in such a case are meant to identify the title of a book or work. The appropriate element to use would be the <cite> element, which is normally shown as italics by browsers.

It seems like a citation in a paragraph that didn't use cite could be a failure if there was no indication of what the italics implies, however, I wouldn't consider not using cite it was on a references page that was marked References?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe remove Example 3 of F2
5 participants