Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-publishing not working #194

Closed
yoavweiss opened this issue Nov 22, 2021 · 8 comments
Closed

Auto-publishing not working #194

yoavweiss opened this issue Nov 22, 2021 · 8 comments

Comments

@yoavweiss
Copy link
Contributor

It seems like auto-publishing is not working, and there are a couple of respec errors. Those 2 facts may be related.. (but would be good to be notified at PR time about the respec errors)

/cc @caribouW3 @marcoscaceres

@marcoscaceres
Copy link
Member

Hey, so all PRs show if continuous integration fails. Click on any PR and you should see ❌ and the reasons why. For example: https://github.com/w3c/performance-timeline/runs/3770850099?check_suite_focus=true

for getting notified when publication fails, auto-publish supports adding an email: https://w3c.github.io/spec-prod/#w3c_notifications_cc

I can add you to the cc if you’d like.

@yoavweiss
Copy link
Contributor Author

Ideally, I'd like the PR to not land if it has errors (similarly to how bikeshed based specs can't land if they don't build).

@marcoscaceres
Copy link
Member

Right, that should be exactly the same already (bikeshed has this issue/feature also): What can happen is between the CI for a pull request passing and something gets merged the world has changed (e.g., the WebIDL parser changed, HTML removes a dfn, etc.).

In those cases, CI also prevents publication: why we are seeing an error right now. Something changed and ReSpec is telling us something is off.

I’ll take a look tomorrow.

@yoavweiss
Copy link
Contributor Author

Cool, thanks!!

@marcoscaceres
Copy link
Member

marcoscaceres commented Nov 25, 2021

Ok, backtracking here.

Ideally, I'd like the PR to not land if it has errors (similarly to how bikeshed based specs can't land if they don't build).

This was already set up. In GitHub's settings, under branch protection:

Screen Shot 2021-11-25 at 12 57 24 pm

This is not a "bikeshed" or "respec" thing: that's controlled by spec-prod (the automatic publication system... and it was again flagging the right thing).

About the actual publication error, please always check the error that CI is emitting. In this case, it was:

Screen Shot 2021-11-25 at 12 59 47 pm

I.e., that the shortname was wrong: "performance-timeline-2-2".

This was cause by .github/workflows/auto-publish.yml:
ca6936d

@yoavweiss, I'm wondering if the problem is that the CI logs are too hard to decipher?

We have a bug to try to improve them, but I need to make sure we are not fixing the wrong thing... or fix them in the right way.

@marcoscaceres
Copy link
Member

marcoscaceres commented Nov 25, 2021

Just noting that auto-publishing is now working again ✅🙏

@yoavweiss
Copy link
Contributor Author

This is not a "bikeshed" or "respec" thing: that's controlled by spec-prod (the automatic publication system... and it was again flagging the right thing).

OK, that's great to know!

@yoavweiss, I'm wondering if the problem is that the CI logs are too hard to decipher?

I haven't put in a ton of time trying to figure this out before filing, so can't say that better CI logs would've change it. I'll investigate more next time!

@marcoscaceres
Copy link
Member

Appreciate it. And always happy to help. At the same time, we are trying to make the tools better so the community can best help themselves without relying so much on the Team 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants