-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify the definition of "navigation scope", "applied", and off-scope theming #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurph
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marcoscaceres
force-pushed
the
apply-off-scope
branch
from
October 31, 2024 23:00
2aae8f9
to
3909577
Compare
marcoscaceres
force-pushed
the
apply-off-scope
branch
from
October 31, 2024 23:02
3909577
to
7177e91
Compare
marcoscaceres
commented
Nov 7, 2024
marcoscaceres
commented
Nov 7, 2024
marcoscaceres
commented
Nov 7, 2024
marcoscaceres
commented
Nov 7, 2024
marcoscaceres
commented
Nov 7, 2024
Co-authored-by: Christian Liebel <christian.liebel@thinktecture.com>
marcoscaceres
commented
Nov 7, 2024
Co-authored-by: Christian Liebel <christian.liebel@thinktecture.com>
marcoscaceres
commented
Nov 7, 2024
christianliebel
approved these changes
Nov 7, 2024
Thanks for cleaning up and landing one of my old PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #880
This is @mgiuca original commit.
Closes #755.
This change (choose one):
changes normative sections without changing behavior)
Commit message:
This further clarifies that a manifest is allowed to apply to URLs that
are not within its scope (that this was not clear was a left-over
mistake from #701), and that a document within scope is allowed to
override the theme color. Adds a new recommendation that an out of scope
document not be allowed to override the theme color.
This introduces new normative recommendations, only insofar as they were
already commonly understood, to my knowledge.
Navigation scope: No longer defined in terms of the URLs that a manifest
is allowed to apply to (since a manifest may apply to any URL). Rather,
it's just a set of URLs; the other normative requirements around
navigation scope define what it means.
Applied: Clarified that it is the user agent's discretion whether or not
to apply a manifest when a top-level browsing context is created, with
examples of when you would and would not apply it (previously, there was
simply no text around when a manifest should be applied).
Theme color: Fixes a "MAY" requirement imposed on the document
(requirements can only be imposed on user agents). Clarifies this
recommendation as only applying to in-scope documents, and adds a
recommendation against applying document theme for out-of-scope
documents.
Preview | Diff