Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the definition of "navigation scope", "applied", and off-scope theming #1151

Merged
merged 12 commits into from
Nov 7, 2024

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Oct 31, 2024

Closes #880

This is @mgiuca original commit.

Closes #755.

This change (choose one):

  • Breaks existing normative behavior (please add label "breaking")
  • Adds new normative requirements
  • Adds new normative recommendations or optional items
  • Makes only editorial changes (only changes informative sections, or
    changes normative sections without changing behavior)
  • Is a "chore" (metadata, formatting, fixing warnings, etc).

Commit message:

This further clarifies that a manifest is allowed to apply to URLs that
are not within its scope (that this was not clear was a left-over
mistake from #701), and that a document within scope is allowed to
override the theme color. Adds a new recommendation that an out of scope
document not be allowed to override the theme color.

This introduces new normative recommendations, only insofar as they were
already commonly understood, to my knowledge.

Navigation scope: No longer defined in terms of the URLs that a manifest
is allowed to apply to (since a manifest may apply to any URL). Rather,
it's just a set of URLs; the other normative requirements around
navigation scope define what it means.

Applied: Clarified that it is the user agent's discretion whether or not
to apply a manifest when a top-level browsing context is created, with
examples of when you would and would not apply it (previously, there was
simply no text around when a manifest should be applied).

Theme color: Fixes a "MAY" requirement imposed on the document
(requirements can only be imposed on user agents). Clarifies this
recommendation as only applying to in-scope documents, and adds a
recommendation against applying document theme for out-of-scope
documents.


Preview | Diff

Copy link
Collaborator

@dmurph dmurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: Christian Liebel <christian.liebel@thinktecture.com>
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
marcoscaceres and others added 2 commits November 7, 2024 22:47
Co-authored-by: Christian Liebel <christian.liebel@thinktecture.com>
index.html Outdated Show resolved Hide resolved
@marcoscaceres marcoscaceres merged commit ec8a23b into main Nov 7, 2024
2 checks passed
@marcoscaceres marcoscaceres deleted the apply-off-scope branch November 7, 2024 12:08
github-actions bot added a commit that referenced this pull request Nov 7, 2024
…e theming (#1151)

SHA: ec8a23b
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@mgiuca
Copy link
Collaborator

mgiuca commented Nov 11, 2024

Thanks for cleaning up and landing one of my old PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What theme color should be used when a PWA window is out of scope?
4 participants