Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed English translation. #127

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fixed English translation. #127

merged 1 commit into from
Aug 30, 2023

Conversation

kaio-donadelli
Copy link
Contributor

What problem is this solving?

Using "each" as a standard unit in English for unitary measurements.

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Aug 10, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I saw that the tests and linting checks had initially failed, but they succeeded after I requested a re-run (we had a temporary problem with those checks).

Feel free to deploy it. Let us know if you need any help.

@kaio-donadelli kaio-donadelli merged commit 2536097 into master Aug 30, 2023
4 checks passed
@kaio-donadelli kaio-donadelli deleted the fix/en-translation branch August 30, 2023 12:13
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Aug 30, 2023

Your PR has been merged! App is being published. 🚀
Version 2.12.2 → 2.12.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.product-customizer@2.12.3

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants