-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CMake build #159
Comments
cb5ac6e is the responsible commit. I think this simple change should fix it: --- a/cmake/expat/CMakeLists.txt
+++ b/cmake/expat/CMakeLists.txt
@@ -1,6 +1,6 @@
project(expat)
-set(SOURCE_DIR ${ROOT_DIR}/3rdparty/expat)
+set(SOURCE_DIR ${ROOT_DIR}/3rdparty/expat/expat)
cmake_minimum_required(VERSION 2.6)
set(PACKAGE_BUGREPORT "expat-bugs@libexpat.org") @drizt (as the one user of the cmake build known to me), any chance you could verify it? |
I've tried - it is much more complicated. |
Sorry :( |
As a matter of sport interest, I have a fix here: Youw@ded0c90 Maybe someone, who more interested in CMake build, might improve it. On the other hand, not entirely correct but working - is better solution, than broken. |
I have own fix. |
@drizt Please submit a PR. Thanks! |
After one of the expat updates, CMake build is no longer working.
I did a quick look at it - the issue is that expat being moved to expat/expat.
Not going to prepare a PR right now - just to keep track of things.
The text was updated successfully, but these errors were encountered: