Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unit Tests for Golife Game #1

Open
vs4vijay opened this issue Sep 30, 2016 · 6 comments
Open

Add Unit Tests for Golife Game #1

vs4vijay opened this issue Sep 30, 2016 · 6 comments

Comments

@vs4vijay
Copy link
Owner

Add Unit Tests for Golife Game

@ghwilley
Copy link
Contributor

I'll work on this!

@ghwilley
Copy link
Contributor

I noticed on the playground generation it starts at 0, so it ends up 11 x 11 due to indexing. Do you want that to stay the same or should I change it to 1 to keep width and height accurate?

@vs4vijay
Copy link
Owner Author

vs4vijay commented Oct 1, 2016

@ghwilley : Hey, Thanks for supporting this. Yes, you can work on this. And you can also make the changes in codebase if you find any bugs or improvement.

btw, Which Testing library will you use? I was thinking about TestUnit?

@ghwilley
Copy link
Contributor

ghwilley commented Oct 1, 2016

@vs4vijay Minitest was already included so I thought I would go ahead on that. I can change it up if you prefer though.

@ghwilley
Copy link
Contributor

ghwilley commented Oct 1, 2016

I'm sorry if this is just my lack of experience or knowledge, but do I need to be added as a contributor in order to push to the repo? I keep getting 'Permission denied'. (I'm on a feature branch).

@vs4vijay
Copy link
Owner Author

vs4vijay commented Oct 1, 2016

@ghwilley Give it a try with Minitest, You have to fork this repo in you profile. Then take clone from it, work on it...and whenever you are ready with your code, Submit Pull Request...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants