move defaults to class so that puppet-strings can build better docs

* I also updated the defaults for arrays to []
* I also updated the defaults for hash to {}
* Add some types to make init.pp a bit more readable

data/os/OpenBSD.yaml

@@ -4,7 +4,8 @@ unbound::pidfile: '/var/run/unbound.pid'
 unbound::logdir: '/var/log/unbound'
 unbound::owner: '_unbound'
 unbound::group: '_unbound'
+unbound::service_name: 'unbound'
 unbound::fetch_client: 'ftp -o'
 unbound::validate_cmd: '/usr/sbin/unbound-checkconf %'
 unbound::package_name: ''
-unbound::restart_cmd: "/usr/sbin/rcctl restart %{hiera('unbound::service_name')}"
+unbound::restart_cmd: "/usr/sbin/rcctl restart %{lookup('unbound::service_name')}"

hiera.yaml

@@ -10,6 +10,4 @@ hierarchy:
     path: "os/%{facts.os.family}/%{facts.os.name}.yaml"
   - name: "family"
     path: "os/%{facts.os.family}.yaml"
-  - name: "common"
-    path: "common.yaml"