Add logfile rotation variables to the telegraf config file #149
Conversation
templates/telegraf.conf.erb
Outdated
| @@ -21,6 +21,15 @@ | |||
| flush_jitter = "<%= @flush_jitter %>" | |||
| precision = "<%= @precision %>" | |||
| logfile = "<%= @logfile %>" | |||
| <% if @logfile_rotation_interval -%> | |||
There was a problem hiding this comment.
can you please implement thats for the options that verify that the content is placed into the template?
There was a problem hiding this comment.
Yes, I set these to use the default values in the params file instead of checking if they were passed.
|
I've never used this CI tool before but I'm kind of confused because it's giving me syntax errors in files that I didn't touch. Should I fix those as well? |
|
that's currently failing because of an updated dependency. I tried to fix that in https://travis-ci.org/github/voxpupuli/puppet-telegraf/builds/714241007 (#147) but I'm not yet sure why the tests fail :( |
|
Dear @jschoewe, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Dear @jschoewe, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
BUMP Any chance of getting this reviewed? |
|
@albatrossflavour thie PR needs to be rebased. If you like you can checkout the branch, rebase it and submit it as new PR |
Pull Request (PR) description
This PR adds optional logfile rotation variables for the telegraf config file. Without these variables our log files are becoming too large and filling up the drive space on our backup servers