-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix apt-key
deprecated message
#1610
base: master
Are you sure you want to change the base?
Conversation
c326f08
to
e1fa81e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the README to say that at least puppetlabs-apt v9.2.0 is needed? That's the version which added support for "modern keyrings". Here in the readme:
Lines 19 to 21 in 12d6b62
* apt is now a soft dependency. If your system uses apt, you'll need to | |
configure an appropriate version of the apt module. Version 4.4.0 or higher is | |
recommended because of the proper handling of `apt-transport-https`. |
https://github.com/puppetlabs/puppetlabs-apt/blob/main/CHANGELOG.md#v920---2023-12-04
11b0886
to
846f12a
Compare
given the "new" version for the dependency, should this be marked backward-incompatible? |
I think yes, because users of this module who use it with puppetlabs-apt would need to update their puppetlabs-apt module. Same as how we've done for this kind of change in other modules. |
c3b21b7
to
7037314
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, missed one other thing. The filenames need to end in .asc
.
I think this also indicates that we are lacking acceptance test coverage.
7037314
to
bf1f44e
Compare
bf1f44e
to
0d15067
Compare
Pull Request (PR) description
In the current implementation, apt::source stores GPG keys in the trusted.gpg file, which is no longer recommended. Additionally, with the deprecation of apt-key, running the apt update command triggers warnings on Debian-based distributions.
This PR modifies the handling of GPG keys so that they are stored in the keyrings directory, aligning with best practices and avoiding the deprecation warnings associated with apt-key