-
-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce Usage Of Managed Repository #1363
base: master
Are you sure you want to change the base?
Conversation
|
||
$_package_install_options ? { | ||
$manage_repo => '--repo=nginx-release', | ||
default => '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably needs to be undef
@@ -31,6 +31,11 @@ | |||
'VirtuozzoLinux' => 'centos', | |||
default => 'rhel' | |||
} | |||
|
|||
$_package_install_options ? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something missing here.
This basically adds RedHat 8 support, right? If so, can you please add CentOS 8 / RedHat 8 to the metadata.json? This depends on voxpupuli/facterdb#137 |
Dear @fzoske, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
Pull Request (PR) description
This change enforce the usage of the managed repository to work around the AppStream of CentOS and RedHat, which will take precedence over none module based repositories.
This Pull Request (PR) fixes the following issues