Skip to content

Commit

Permalink
dont run unit tests on limited amount of OSes
Browse files Browse the repository at this point in the history
In the past we restricted rspec-puppet tests to certain operating
systems. This is hacky to maintain. We should try again to run it on all
OSes, like we do it everywhere else.
  • Loading branch information
bastelfreak committed Jun 27, 2024
1 parent fd1e903 commit 4fa4363
Show file tree
Hide file tree
Showing 89 changed files with 88 additions and 99 deletions.
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_amqp1_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::amqp1', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_amqp_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::amqp', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_apache_instance_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::apache::instance', type: :define do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_apache_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::apache', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_battery_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::battery', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_bind_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::bind', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_ceph_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::ceph', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_cgroups_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::cgroups', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_connectivity_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::connectivity', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_cpu_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::cpu', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_cuda_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::cuda', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_curl_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::curl', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_dbi_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::dbi', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_dcpmm_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::dcpmm', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_df_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::df', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_disk_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::disk', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_dns_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::dns', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_dpdk_telemetry_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::dpdk_telemetry', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_ethstat.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::ethstat', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_exec_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::exec', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_fhcount_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::fhcount', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_filecount_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::filecount', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_filter_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::filter', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_genericjmx_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::genericjmx', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
options = os_specific_options(facts)
let :facts do
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_hddtemp_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::hddtemp', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_hugepages_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::hugepages', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_intel_pmu_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::intel_pmu', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_intel_rdt_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::intel_rdt', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_interface_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::interface', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_ipmi.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::ipmi', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
options = os_specific_options(facts)
let :facts do
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_iptables_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::iptables', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_irq_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::irq', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_iscdhcp_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::cuda', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_java_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::java', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_load_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::load', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_logfile_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::logfile', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_logparser_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::logparser', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_mcelog_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::mcelog', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_memcached_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::memcached', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_memory_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::memory', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_mongodb_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}
end

on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_mysql_database_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::mysql::database', type: :define do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_netlink_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::netlink', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/collectd_plugin_network_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require 'spec_helper'

describe 'collectd::plugin::network', type: :class do
on_supported_os(baseline_os_hash).each do |os, facts|
on_supported_os.each do |os, facts|
context "on #{os}" do
let :facts do
facts
Expand Down
Loading

0 comments on commit 4fa4363

Please sign in to comment.