Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for Holley DTZ541 #76

Merged
merged 4 commits into from
Oct 31, 2019
Merged

Workaround for Holley DTZ541 #76

merged 4 commits into from
Oct 31, 2019

Conversation

hacki11
Copy link

@hacki11 hacki11 commented Sep 22, 2019

  • handling incorrect sml_time object
  • support crc-16/kermit algorithm

@hacki11
Fix Issues
763e33c 
- handling incorrect sml_time object
- support crc-16/kermit algorithm
@hacki11 hacki11 mentioned this pull request Sep 22, 2019
Closed
mbehr1
mbehr1 requested changes Sep 22, 2019
View reviewed changes
Copy link

@mbehr1 mbehr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments. mem leak introduced.

sml/src/sml_time.c Outdated Show resolved Hide resolved
mbehr1
mbehr1 approved these changes Sep 23, 2019
View reviewed changes
Copy link

@mbehr1 mbehr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for me.

sml/src/sml_time.c Outdated Show resolved Hide resolved
@hacki11
Copy link
Author

hacki11 commented Oct 8, 2019

Fixed review findings

@hacki11 hacki11 mentioned this pull request Oct 11, 2019
Closed
@hacki11
Copy link
Author

hacki11 commented Oct 29, 2019

If there aren’t any more findings a merge would be nice

@andig
Copy link

andig commented Oct 29, 2019

Out of curiosity- why the unrelated whitespace change? Does that make anything more consistent?

@hacki11
Copy link
Author

hacki11 commented Oct 30, 2019

Seems that was my auto formatting of clion. Perhaps tab replacement with whitespaces and indentation fixes. Can revert that changes if you want.

@andig
Copy link

andig commented Oct 30, 2019

Please revert unwanted changes and check style- this repo is typically using tabs, you have spaces apparently. Reformatting the entire codebase would be a different issue.

@hacki11
Copy link
Author

hacki11 commented Oct 30, 2019

fixed

andig
andig reviewed Oct 30, 2019
View reviewed changes
sml/src/sml_time.c
if (sml_buf_get_next_length(buf) != 2) {
buf->error = 1;
goto error;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier stimmt noch die Einrückung nicht?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doch, der Block gehört nun in den else Zweig

@andig andig merged commit 36fc784 into volkszaehler:master Oct 31, 2019
@andig
Copy link

andig commented Oct 31, 2019

Fixes #75

@andig andig mentioned this pull request Mar 28, 2020
Closed
@hacki11 hacki11 mentioned this pull request Oct 23, 2020
Merged
@DenisMir DenisMir mentioned this pull request Sep 26, 2021
Closed
This was referenced Oct 31, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig andig left review comments

@mbehr1 mbehr1 mbehr1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacki11 @andig @mbehr1