Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Sequence to Segments #277

Open
NickleDave opened this issue Oct 11, 2024 · 0 comments
Open

Rename Sequence to Segments #277

NickleDave opened this issue Oct 11, 2024 · 0 comments
Labels
ENH: enhancement New feature or request

Comments

@NickleDave
Copy link
Collaborator

to match vocalpy: vocalpy/vocalpy#127

This would obviously be breaking change but I think it's important to do this, to convey that these annotation formats are the result of segmentation, and to reserve the word "sequence" to mean "a sequence of sounds produced by an animal" -- a sequence is by definition made up of segments, but not all segments are part of a sequence

We could also change the actual implementation when we do so -- I need to revisit + reread the code in detail but when I skim now I get the feeling it could be simplified, e.g. we could represent a set of line segments with a dataframe and then switch the implementation of properties like onsets_s to just return the column as values instead of the setter/getter pattern we use now.

@NickleDave NickleDave added the ENH: enhancement New feature or request label Oct 11, 2024
@NickleDave NickleDave moved this to Todo in crowsetta-6.0 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENH: enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant