Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Altfan uses unsupported timer mode #202

Open
vintagepc opened this issue Aug 5, 2020 · 1 comment
Open

[BUG] Altfan uses unsupported timer mode #202

vintagepc opened this issue Aug 5, 2020 · 1 comment
Labels
bug Something isn't working Hardware sim Simulated hardware help wanted Extra attention is needed upstream Something that should be fixed or submitted upstream

Comments

@vintagepc
Copy link
Owner

Describe the bug
Altfan uses mode 9 on timer 4. This is unsupported by SimAVR.

To Reproduce
Steps to reproduce the behavior:
Run altfan firmware with -vvv
Observe: TIMER: avr_timer_write_ocr-4 mode 0 UNSUPPORTED

Expected behavior
A functional mode 9

Additional context
Maybe roll this in with a fix for the missing PC PWM mode...?? (#75 )

@vintagepc vintagepc added bug Something isn't working Hardware sim Simulated hardware upstream Something that should be fixed or submitted upstream labels Aug 5, 2020
@vintagepc vintagepc modified the milestone: 1.0 Aug 5, 2020
@vintagepc
Copy link
Owner Author

Casually poking at this, it looks like the implementation should be fairly straightforward with existing timer code as reference.
The only thing I'm struggling to understand is how the specific updating of TOV or OCRs is controlled. It's a little clearer in the external clocking function but I can't make heads nor tails of the internal clock configuration for a timer.

image

@vintagepc vintagepc added the help wanted Extra attention is needed label Aug 6, 2020
@vintagepc vintagepc modified the milestone: Wishlist Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hardware sim Simulated hardware help wanted Extra attention is needed upstream Something that should be fixed or submitted upstream
Projects
None yet
Development

No branches or pull requests

1 participant