Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension is not working #115

Open
nirmalsinghoo7 opened this issue Aug 18, 2020 · 8 comments
Open

Extension is not working #115

nirmalsinghoo7 opened this issue Aug 18, 2020 · 8 comments

Comments

@nirmalsinghoo7
Copy link

I have enabled all of the required settings. But the extension is not working.
hight light 1

But it's not working. It just highlights whole tags.
It has to highlight the selected tag. Please see the screenshot. I have marked the selected div.
hight light 2

@vincaslt
Copy link
Owner

Could you check if your console says anything?
image

It could also be that the highlighting that vscode puts on top in html files hides or overrides the one added by the extension - could you try creating a new file, and setting language as javascript, and pasting in:

<div attr></div>

then put cursor anywhere on attr (this will not trigger vscode highlighting) and see if it's working like this:
image

@nirmalsinghoo7
Copy link
Author

Yes, It's showing two errors in the console. I have tried by uninstall and install again. but not working. I have tried in a new file. I have tried by .php and .html file extension, but not working
console error

@vincaslt
Copy link
Owner

Doesn't seem like the errors are from this extension. It could be that your settings JSON file is somehow invalid, could you try to resolve the errors, or disable other extensions - leaving only this one on?

@findyourneechie
Copy link

I am having the same issue. This has occurred since and update in august in vs code. All file extensions I've tested (html, css, js, php) do not underline and highlight anymore even with all selections checked on.

@vincaslt
Copy link
Owner

vincaslt commented Oct 5, 2020

Can you try to change styling settings? The default ones might be hidden behind default highlighting in vscode.

@ruffin--
Copy link

ruffin-- commented Aug 5, 2021

I'm seeing something similar -- well, I'm also seeing nothing, I think. Does this look like the extension is working to you?

simplest case test with cursor in attr

I received no errors while creating that new file and placing my cursor in attr.

Same deal with all other extensions disabled.

disabled extensions

@vincaslt
Copy link
Owner

vincaslt commented Aug 5, 2021

I'm pretty sure I can see yellow underline. It might be that default theme settings stopped working correctly for some reason or your theme reports it's color settings incorrectly (as dark theme instead of light). You can try changing color settings for this extension, e.g. to have black underline.

@ruffin--
Copy link

ruffin-- commented Aug 6, 2021

Yep, you're right. It's just understated.

Looks like it doesn't work if the html is invalid. I had an extra " in an attribute, and poof, toast.

I'd probably ask the OP to paste in their full html then run it in a tool that'll validate your html and give you feedback like Prettier online (here's what I saw when I tried mine and clued in), then see if it doesn't fire back up.

So imo this isn't a great tool for debugging while you're authoring (when VSCode's tag matching still attempts to work), but is better for scanning an already perfect file. Or being the canary that tells you your html isn't quite solid. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants