Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Python deps to cmd.python #482

Open
mvgijssel opened this issue Aug 30, 2023 · 0 comments
Open

Move Python deps to cmd.python #482

mvgijssel opened this issue Aug 30, 2023 · 0 comments

Comments

@mvgijssel
Copy link
Member

mvgijssel commented Aug 30, 2023 •
edited
Loading

Currently the Python deps are added directly to the Task py_binary runner target. Therefore the runner needs to be a second target generated by the task (and task_test) rule. By moving the python dependencies into the cmd.python nodes we can remove this dependency and move the runner back into the rule!

This would cleanup #325 somewhat!

While working on #451 noticed it's pretty cumbersome to get secrets into a task.
@mvgijssel mvgijssel converted this from a draft issue Aug 30, 2023
@mvgijssel mvgijssel moved this from In Progress to Todo in rules_task Aug 31, 2023
@mvgijssel mvgijssel moved this to Todo in rules_task Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
rules_task
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvgijssel