Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout param to ledger interactions #2124

Open
0xArdi opened this issue Dec 4, 2023 · 0 comments
Open

Add timeout param to ledger interactions #2124

0xArdi opened this issue Dec 4, 2023 · 0 comments
Labels
core-packages Related to core packages enhancement New feature or request

Comments

@0xArdi
Copy link
Collaborator

0xArdi commented Dec 4, 2023 

          This is duplicated on purpose to avoid introducing deps between the contracts. I think it should ultimately be something offered by the ledger connection, as it already is executing these ledger interactions in a ThreadPoolExecutor.

I think we should extend the current contract_api and ledger_api protocol to include an optional timeout field.

Originally posted by @0xArdi in valory-xyz/trader#168 (comment)
@0xArdi 0xArdi added the core-packages Related to core packages label Dec 4, 2023
@DavidMinarsch DavidMinarsch added the enhancement New feature or request label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core-packages Related to core packages enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidMinarsch @0xArdi