feat: Updates for service form & network dropdown #22
Conversation
mohandast52
added
bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Duplicate file
There was a problem hiding this comment.
Duplicate file
mohandast52
changed the title
| callback(hash); | ||
| } | ||
| }) | ||
| .catch(() => { |
There was a problem hiding this comment.
not high priority
this .catch renders the try catch block surrounding the code redundant, can remove
| @@ -11,14 +11,16 @@ export const URL = { | |||
| DISCLAIMER: '/disclaimer', | |||
| PAGE_NOT_FOUND: '/page-not-found', | |||
| NOT_LEGAL: '/not-legal', | |||
| }; | |||
| } as const; | |||
There was a problem hiding this comment.
nice, this is super useful, will use myself moving forward
apps/autonolas-registry/components/ListServices/ServiceState/2StepActiveRegistration/index.jsx
Show resolved
Hide resolved
apps/autonolas-registry/components/ListServices/helpers/RegisterForm.jsx
Show resolved
Hide resolved
| /** | ||
| * validates the threshold based on the no. of slots | ||
| */ | ||
| const validateThreshold = ( |
There was a problem hiding this comment.
@mohandast52 @truemiller what are your thought on keeping these utils and constants in separate files close to the Component e.g.
ComponentFolder
| Component.tsx
│ utils.ts
| hooks.ts
| constants.ts
etc
There was a problem hiding this comment.
@Tanya-atatakai @truemiller I believe we shouldn't create separate files for individual components or functions. If a component or a function isn't going to be used by any other component or function, we can consider it a private component or function. It's better to keep these in the same file to provide abstraction. Of course, if a component grows larger, we break it into smaller chunks. However, maintaining a separate file for every component is very cumbersome. WDYT?
There was a problem hiding this comment.
utils
functions
stringManipulations.js
stringManipulations.test.js
ethParsers.js
ethParsers.test.js
graphFunctions.js
graphFunctions.test.js
constants
dogs.js
cats.js
metaData.js
graphQueries.js
components
Layout
Layout.jsx
Layout.test.jsx
Header.jsx
Header.test.jsx
Footer.jsx
Footer.test.jsx
MagicButton
MagicButton.jsx
MagicButton.test.jsx
Table
Table.jsx
Table.test.jsx
DogDisplay
Dog.jsx
Dog.test.jsx
DogTail.jsx
DogTail.test.jsx
CatDisplay
Cat.jsx
Cat.test.jsx
CatBowl.jsx
CatBowl.test.jsx
hooks
useDog.js
useDog.test.js
useCat.js
useCat.test.js
pages
index.jsx
comparison.jsx
dog.jsx
cat.jsx
contact.jsx
this way we know what files to expect in each folder without having to dig or being confused when we find a utils.jsx in a component folder, or some import from another component's folder if the utils or helper functions are reused and not moved to a common folder
we should consider functions and utils as reusable especially if they are exported, and seperate them from components within reason.
if a function or constant value is truly private to a component or hook, we can leave it outside the component definition in the component file, not exported, provided it's not huge. in which case, it probably deserves to be made more succinct, or split into reusable elements. or.. we include it in the component, and use some memoization through useMemo or useCallback
| @@ -123,4 +124,36 @@ describe('listAgents/details.jsx', () => { | |||
| ); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should display update hash button only for owner and open the modal when clicked', async () => { | |||
There was a problem hiding this comment.
kudos for tests!!! 👍
Co-authored-by: Atatakai <densatsu@mail.ru>
…autonolas-frontend-mono into mohan/minor-updates
Proposed changes
Fixes
Update.hash.mov
NOTE: The Service update button should be visible only to the owner and should redirect to the
/updatepage.threshold.mov
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply