-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binder.validate() no longer fails with "bean level validators have been configured but no bean is currently set" when in buffered mode #18121
base: main
Are you sure you want to change the base?
Conversation
…el validations are defined. Fixes #18120
…s() to perform explicit checks
Test Results1 092 files ± 0 1 092 suites ±0 1h 21m 52s ⏱️ -42s Results for commit 1a5d08d. ± Comparison against base commit dc68b28. This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This should be postponed until major release of Flow (25), as this is a behaviour change. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Description
This PR makes the Binder.validate() implementation in line with its javadoc. Namely, Binder.validate() no longer fails with "bean level validators have been configured but no bean is currently set" when in buffered mode, which is according to the current javadoc: "Bean level validators are ignored if there is no bound bean or if any field level validator fails."
Fixes #18120
Type of change
Checklist
Additional for
Feature
type of change