Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: introduce Contribution Guidlines #646

Open
ENDrain opened this issue Apr 19, 2021 · 1 comment
Open

Suggestion: introduce Contribution Guidlines #646

ENDrain opened this issue Apr 19, 2021 · 1 comment

Comments

@ENDrain
Copy link
Contributor

ENDrain commented Apr 19, 2021

Since I can't keep but notice some PRs turned down not because of quality of code per se, but due to failure to comply with unspoken contribution standards of this project, which include but are not limited to: commit messages, code styling, naming conventions, commentary or documentation coverage, etc. etc.; with deepest respect to the maintainer of this repository may I suggest introducing contribution guidlines, in a form of CONTRIBUTING.md file, a section in README.md, or any form or shape they find appropriate; in order to prevent any hindrances in acceptance of community contributions in the future.

@ImagicTheCat
Copy link
Member

ImagicTheCat commented Apr 20, 2021

Since you insist on that on multiples PR... e.g. #636.
Those things will not solve magically because I put a CONTRIBUTING.md file. This file is useful for people wanting to read it, not for people trying their best to contribute on a project sometimes without knowing what they are doing because they are learning Lua/git/GitHub at the same time (and I'm fine with that). And the project didn't receive enough contributions to make this mandatory either.

As you can see, people don't necessarily fix what I point out and that's when I have time/will to point it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants