Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add clang-tidy testing #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

coldav
Copy link
Collaborator

@coldav coldav commented Jul 18, 2023

Overview

Add clang-tidy testing

Reason for change

clang-tidy testing does not yet exist on github.

Description of change

Added a job in the PR testing workflow to build the minimum target, compute dependencies and run clang-tidy on the result,
based on what files have changed.

Checklist

  • Read and follow the project Code of Conduct.
  • Make sure the project builds successfully with your changes.
  • Run relevant testing locally to avoid regressions.
  • Run clang-format-9 on all modified code.

@coldav coldav force-pushed the colin/add_clang_tidy_pr_testing branch from f0a3881 to c0f9916 Compare July 18, 2023 08:19
@coldav coldav changed the title Add clang-tidy testing Draft: Add clang-tidy testing Jul 18, 2023
@coldav coldav force-pushed the colin/add_clang_tidy_pr_testing branch 16 times, most recently from 8f27aa9 to d960543 Compare July 18, 2023 12:47
@coldav coldav changed the title Draft: Add clang-tidy testing Add clang-tidy testing Jul 18, 2023
@coldav coldav force-pushed the colin/add_clang_tidy_pr_testing branch from d960543 to d496e08 Compare July 20, 2023 14:17
@coldav coldav changed the title Add clang-tidy testing DRAFT: Add clang-tidy testing Jul 26, 2023
@coldav coldav force-pushed the colin/add_clang_tidy_pr_testing branch from d496e08 to 17f6674 Compare October 4, 2023 16:48
@coldav coldav force-pushed the colin/add_clang_tidy_pr_testing branch 2 times, most recently from 11a0188 to 3b087c7 Compare July 19, 2024 17:15
Added an extra workflow job to do clang-tidy testing. This does an
initial build before calculating dependencies and then calling clang-tidy.

Switched to using clang-tidy-12 (in the CMakelists.txt and the job)
@coldav coldav force-pushed the colin/add_clang_tidy_pr_testing branch from 3b087c7 to a3bce43 Compare October 15, 2024 14:05
@coldav coldav requested a review from a team as a code owner October 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants