Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query about max quality #4

Open
johnnyshield opened this issue Jul 28, 2021 · 3 comments
Open

Query about max quality #4

johnnyshield opened this issue Jul 28, 2021 · 3 comments

Comments

@johnnyshield
Copy link

image

Thanks for your work on this tool, generally I'm getting great results, but occasionally I'm having issues with rough geometry on the output, despite the file size being quite small (3MB)

Checking the NIST SFA gui - low medium high options correspond to --quality flag of 4, 7 & 9 vs. range 1 - 10 available in STP2X3D.cpp.

Can you please advise if it output precision is limited by this range (and could be modified), or if this is a limitation of OCCT?

NB: I haven't tried using STP2X3D (not permitted to install Cmake at work), so just using the NIST SFA gui.

@robert-lipman
Copy link

Johnny, can you share the STEP file here or send it to robert.lipman@nist.gov. I'm the developer of SFA and would like to test the quality with your file.

@johnnyshield
Copy link
Author

Funnel.zip

Posting the example file here as well (emailed to Robert), highlighted the sawtooth geometry on output

image

https://github.com/usnistgov/SFA

@soonjokwon
Copy link
Collaborator

soonjokwon commented Nov 24, 2021

Hi. Sawtooth mesh is not actually a problem. If something breaks, then that is the problem.
This bad geometry might be happening due to inadequate tessellation parameters.

Currently, we use the same tessellation parameters for all STEP files regardless of dimension.
We plan to adjust tessellation parameters per body or model in the near future.
However, this doesn't ensure that sawtooth-like geometry would never happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants