Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap242 GDT abnormal #10

Open
N3GIS opened this issue Apr 11, 2023 · 3 comments
Open

ap242 GDT abnormal #10

N3GIS opened this issue Apr 11, 2023 · 3 comments

Comments

@N3GIS
Copy link

N3GIS commented Apr 11, 2023

image
The ap242 STP format model, GDT does not display correctly.

The STP model download address for AP242.
https://www.nist.gov/system/files/documents/noindex/2023/02/22/NIST_CTC_STEP_PMI.zip

@soonjokwon
Copy link
Collaborator

Hi. The current code highlights only the faces GD&T assigned, not graphic PMIs.
GDTs are not shown correctly because the current OCCT does not successfully translate the graphic PMIs from STEP files.

@N3GIS
Copy link
Author

N3GIS commented Apr 11, 2023

This is indeed a bug in OCCT.
I see that you have the following paragraph in your code:

// STEP_Reader.cpp ,In line 566 position
double val = aDimObject->GetValue();
double lowerTolVal = aDimObject->GetLowerTolValue();
double lowerBoundVal = aDimObject->GetLowerBound();
double upperTolVal = aDimObject->GetUpperTolValue();
double upperBound = aDimObject->GetUpperBound();

Now that the val value has been obtained, I want to dynamically create a TDF_Label, assign the val value to the TDF_Label, and then convert the TDF_Label to TopoDS_Shape and add it to the gdt, I want to fix the OCCT bug in this way, but it didn't work, I don't know if it works.

@soonjokwon
Copy link
Collaborator

I know that the values can be obtained.
These are "Semantic GDTs" from STEP files.
But the problem is "Graphic GDTs" from STEP files.
They are dots and lines that graphically represent the GDTs in 3D space.
I don't think you can create Graphic from Semantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants