Merge pull request #348 from usefulness/updates

Respect RMS tolerance
usefulness · Oct 9, 2024 · b54775a · b54775a
2 parents 1376fc4 + 17ead15
commit b54775a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 26 deletions.
diff --git a/sample/settings.gradle b/sample/settings.gradle
@@ -17,20 +17,6 @@ pluginManagement {
     }
 }
 
-plugins {
-    id("com.gradle.develocity") version "3.18.1"
-}
-
-develocity {
-    buildScan {
-        termsOfUseUrl = "https://gradle.com/terms-of-service"
-        termsOfUseAgree = "yes"
-
-        uploadInBackground = System.getenv("CI") == null
-        publishing { onlyIf {  System.getenv("CI") != null } }
-    }
-}
-
 rootProject.name = "io.github.usefulness.testing.screenshot.sample"
 
 include "android"

diff --git a/...g-plugin/src/main/kotlin/io/github/usefulness/testing/screenshot/verification/Recorder.kt b/...g-plugin/src/main/kotlin/io/github/usefulness/testing/screenshot/verification/Recorder.kt
@@ -61,7 +61,12 @@ internal class Recorder(
             }
 
             is ComparisonMethod.RootMeanSquareErrorValue -> { existing, incoming ->
-                existing.getRootMeetSquare(incoming)
+                val rms = existing.getRootMeetSquare(incoming)
+                if (rms > comparisonMethod.tolerance) {
+                    rms
+                } else {
+                    0
+                }
             }
         }
 

diff --git a/settings.gradle b/settings.gradle
@@ -17,17 +17,6 @@ pluginManagement {
 
 plugins {
   id("org.gradle.toolchains.foojay-resolver-convention") version "0.8.0"
-  id("com.gradle.develocity") version "3.18.1"
-}
-
-develocity {
-  buildScan {
-    termsOfUseUrl = "https://gradle.com/terms-of-service"
-    termsOfUseAgree = "yes"
-
-    uploadInBackground = System.getenv("CI") == null
-    publishing { onlyIf { false } }
-  }
 }
 
 dependencyResolutionManagement {