Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment keybind no longer supports XML formatted comment #3519

Open
2 tasks done
jdunster-bw opened this issue Nov 20, 2024 · 1 comment
Open
2 tasks done

Comment keybind no longer supports XML formatted comment #3519

jdunster-bw opened this issue Nov 20, 2024 · 1 comment
Assignees
Labels

Comments

@jdunster-bw
Copy link

I have checked the following:

  • I use the newest version of bruno.
  • I've searched existing issues and found nothing related to my issue.

Describe the bug

I often use the ⌘ + / keybind to comment out certain parts of a request that I'm debugging. I recently updated my Bruno version to the latest version though (1.34.2) and this seems to have broken that functionality for XML. Prior to the upgrade, I was using version 1.23.0.

Previously, when using the keybind, it would comment out sections in XML style, wrapping it in <!-- --> or removing the wrapping from a commented-out line or section. Now, it just adds or removes // from the start of the line which produces invalid XML. This is especially annoying in existing Bruno files which have commented-out lines that I'd like to include, as now they need to be commented/uncommented manually.

I suspect this was introduced by #2634, as this made some changes meant to allow the comment keybind to work with JSON, but the behavior might be spilling over to XML editing as well.

.bru file to reproduce the bug

Example Collection.json

Screenshots/Live demo link

Behavior before updating:

comment_xml_example_before.mov

Behavior after updating:

comment_xml_example.mov
@jdunster-bw jdunster-bw added the bug Something isn't working label Nov 20, 2024
@sreelakshmi-bruno sreelakshmi-bruno self-assigned this Nov 21, 2024
@sreelakshmi-bruno
Copy link
Collaborator

Hi @jdunster-bw, thanks for reporting this issue. We'll work on it and will post the updates here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants