Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][UITests] When_Override_Insets takes 20+ minutes per run #1232

Open
kazo0 opened this issue Aug 27, 2024 · 0 comments
Open

[iOS][UITests] When_Override_Insets takes 20+ minutes per run #1232

kazo0 opened this issue Aug 27, 2024 · 0 comments
Labels
area/tests Categorizes an issue or PR as relevant to testing control/safe-area kind/enhancement New feature or request.

Comments

@kazo0
Copy link
Contributor

kazo0 commented Aug 27, 2024

uno.toolkit.ui/src/Uno.Toolkit.UITest/Controls/SafeArea/Given_SafeArea.cs

Line 117 in 1dc15d3

public void When_Override_Insets(string mode, string safeAreaType)

This test is taking 20+ minutes per permutation from the test cases on iOS

In WASM the test takes less than a minute

These could be converted to runtime tests instead by RenderTargetBitmap comparison or perhaps calculating the bounds of the root elements
@kazo0 kazo0 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification. area/tests Categorizes an issue or PR as relevant to testing control/safe-area and removed triage/untriaged Indicates an issue requires triaging or verification. labels Aug 27, 2024
@kazo0 kazo0 mentioned this issue Aug 27, 2024
Open
@kazo0 kazo0 added kind/enhancement New feature or request. and removed kind/bug Something isn't working labels Aug 27, 2024
@kazo0 kazo0 mentioned this issue Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests Categorizes an issue or PR as relevant to testing control/safe-area kind/enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kazo0