This repository has been archived by the owner on Jul 25, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This updates all the dependencies to their latest versions. With the new TypeScript version, it broke some of the routing code, as Express is typed to give a plain request and response object in middleware, and some of the Controller methods place some requirements on the request/response that lead to type errors. We know that this is still safe however since we are using the appropriate middlewares before the controller methods.
For now, I fixed it by just casting the controller methods to
any
, but we should look into a proper way to type this at some point later on. It doesn't seem trivial to do now.