Skip to content
This repository has been archived by the owner on Jul 25, 2021. It is now read-only.

deps: update all dependencies #82

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

deps: update all dependencies #82

wants to merge 2 commits into from

Conversation

amishshah
Copy link
Collaborator

About

This updates all the dependencies to their latest versions. With the new TypeScript version, it broke some of the routing code, as Express is typed to give a plain request and response object in middleware, and some of the Controller methods place some requirements on the request/response that lead to type errors. We know that this is still safe however since we are using the appropriate middlewares before the controller methods.

For now, I fixed it by just casting the controller methods to any, but we should look into a proper way to type this at some point later on. It doesn't seem trivial to do now.

@amishshah amishshah added the dependencies Pull requests that update a dependency file label Sep 7, 2020
@amishshah amishshah requested a review from a team September 7, 2020 19:42
@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #82 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files          38       38           
  Lines         941      941           
  Branches      125      125           
=======================================
  Hits          782      782           
  Misses        159      159           
Impacted Files Coverage Δ
src/routes/ChannelRoutes.ts 100.00% <100.00%> (ø)
src/routes/EventRoutes.ts 100.00% <100.00%> (ø)
src/routes/UserRoutes.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff7048...842c3e2. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant