Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node client with umami cloud - user-agent drive some ignore/reject (ex. isBot) #7

Open
boly38 opened this issue Nov 6, 2024 · 0 comments

Comments

@boly38
Copy link
Contributor

boly38 commented Nov 6, 2024

I'm using umami node client (from an electron app) with umami cloud instance and I encounter some issue over "user-agent" field depending of its value.

Example of (good) User-Agent value :

User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.6099.268 Electron/28.2.1 Safari/537.36

After like Gecko) , we could see multiple <product/version> instances.
Here is what I saw during my tests:

  • if some product includes -, then the hit seems to be ignored by umami cloud
  • if some version includes something else than digit and dot, then the hit seems to be ignored by umami cloud
  • if some product includes bot in the value, then the hit will be considered as bot origin and umami ignore and reply with {"beep":"boop"}
    NB: via Similar to electron framework application API response {"beep": "boop"} umami#2833 I understand that with docker hosted version we could use DISABLE_BOT_CHECK=1 to disable robot check, but not applicable here when using umami cloud.

As node client user I would like

At least It would be great if this issue can handle {"beep":"boop"} response to reject the call.
It would be really great that umami backend reject the call in case of ignored/invalid user-agent (ex. 4xx) or else better handle more use-cases according to RFC accepted token format.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant