Second reconciliation PR from production/RRFS.v1 #2481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
14 tasks
jkbk2004
pushed a commit
that referenced
this pull request
Nov 8, 2024
…n PR from production/RRFS.v1 #2481 (#2458) * UFSWM - Enable some of the intel llvm tests in rt conf * UFSWM - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables * FV3 - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables * ccpp-physics - Second reconciliation PR from production/RRFS.v1 related to FV3 unused and optional variables --------- Co-authored-by: Grant Firl <grant.firl@noaa.gov>
|
merged with #2458 |
tsga
added a commit
to tsga/ufs-weather-model
that referenced
this pull request
Nov 13, 2024
* develop: Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + ufs-community#2459 (ufs-community#2461) Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 ufs-community#2481 (ufs-community#2458) Fix/cpld sfs rt + Pull in units updates from FV3 ufs-community#2467 (ufs-community#2475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This work is synonymous with #2158. See NOAA-EMC/fv3atm#881 for most of the work, which is primarily cleanup of unused variables and metadata. The original PR into production/RRFS.v1 also had many changes related to always allocating conditionally-allocated variables in fv3atm (at least to zero size) due to NCO's requirement that code pass the
-check alldebug flag, but those changes are no longer required due to other changes in fv3atm and ccpp-framework. This work has been tested with the-check allflag added to the cmake debug mode as in https://github.com/ufs-community/ufs-weather-model/pull/2158/files#diff-077be989f84571193e53c052e8bfecd6f073df5ce504350826c657d023c10bfb, although those changes ARE NOT included in this PR since it is beyond the scope of my work and I'm unsure whether all components will work with it (or even inherit all compilation flags from ufs-weather-model).Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: