Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submodule pointer update for ccpp-framework/ccpp-physics & option to run compile jobs of regression test suite only & -mcmodel=medium gnu.cmake option (also includes https://github.com/ufs-community/ufs-weather-model/pull/2142) #2066

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 28, 2023

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

  1. Update submodule pointer for FV3ATM (and ccpp-framework, ccpp-physics) for the changes described in the associated PRs below.
  2. Add option to rt.sh to run compile-only tests. This may get reverted based on @DusanJovic-NOAA's feedback.

Commit Message:

* UFSWM - Add option to `rt.sh` to run compile-only tests
  * FV3 - Update submodule pointer (NOAA-EMC/fv3atm#747)
    * ccpp-physics - Update submodule pointer (ufs-community/ccpp-physics#150)
    * ccpp-framework - Update submodule pointer (NCAR/ccpp-framework#519)

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@climbfuji climbfuji marked this pull request as ready for review December 28, 2023 22:36
@climbfuji climbfuji self-assigned this Dec 28, 2023
@zach1221 zach1221 added the Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. label Feb 22, 2024
@zach1221
Copy link
Collaborator

@DomHeinzeller I meant to ask previous, but would you be able to combine in ufs-wm PR #2142 into this one? It should just be documentation updates.

@climbfuji
Copy link
Collaborator Author

#2142

Ok, let me pull this in.

@climbfuji climbfuji changed the title Submodule pointer update for ccpp-framework/ccpp-physics & option to run compile jobs of regression test suite only & -mcmodel=medium gnu.cmake option Submodule pointer update for ccpp-framework/ccpp-physics & option to run compile jobs of regression test suite only & -mcmodel=medium gnu.cmake option (also includes https://github.com/ufs-community/ufs-weather-model/pull/2142) Feb 23, 2024
@climbfuji
Copy link
Collaborator Author

#2142

Ok, let me pull this in.

Done

@BrianCurtis-NOAA
Copy link
Collaborator

Acorn still unavailable. If merging soon, can skip.

@zach1221
Copy link
Collaborator

Acorn still unavailable. If merging soon, can skip.

Ok, let me post the ORT logs and we can start the process.

@zach1221
Copy link
Collaborator

Testing is complete, we can begin the merging process of the ccpp-physics PRs.

@zach1221
Copy link
Collaborator

Ok, @climbfuji fv3atm has been merged as well.
hash: NOAA-EMC/fv3atm@2d34223

@climbfuji
Copy link
Collaborator Author

I updated the submodule pointer and reverted the .gitmodules change, please check. Thanks!

@zach1221
Copy link
Collaborator

I updated the submodule pointer and reverted the .gitmodules change, please check. Thanks!

Thank you!

@zach1221
Copy link
Collaborator

@jkbk2004 @BrianCurtis-NOAA PR ready for review.

@zach1221 zach1221 merged commit d87b54c into ufs-community:develop Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No Baseline Change Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nice to have: option to run compile jobs of regression test suite only
8 participants