Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop]: Merge relevant release documentation updates into develop #963

Merged
merged 47 commits into from
Jan 12, 2024

Conversation

gspetro-NOAA
Copy link
Collaborator

@gspetro-NOAA gspetro-NOAA commented Nov 2, 2023

DESCRIPTION OF CHANGES:

A variety of updates to the release v2.2.0 documentation are relevant to the develop branch and are being incorporated via this PR.

Type of change

  • This change requires a documentation update

TESTS CONDUCTED:

None required. Docs for my fork can be viewed at: https://srw-ug.readthedocs.io/en/text-cleanup/index.html

  • hera.intel
  • orion.intel
  • hercules.intel
  • cheyenne.intel
  • cheyenne.gnu
  • derecho.intel
  • gaea.intel
  • gaeac5.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

None.

DOCUMENTATION:

All documentation.

ISSUE:

Fixes #962 .

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain). N/A
  • My changes generate no new warnings
  • New and existing tests pass with my changes N/A - no tests required for doc changes
  • Any dependent changes have been merged and published

CONTRIBUTORS (optional):

@natalie-perlin

@MichaelLueken
Copy link
Collaborator

@gspetro-NOAA - The modifications that you made in the tables/Test.csv file in PR #950 should also be applied to this PR's documentation update as well.

The FV3_GFS_2017_gfdlmp CCPP suite has been removed, so the grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_2017_gfdlmp WE2E test should be renamed as done in #950. Additionally, the grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16 WE2E test was renamed to grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16_plot.

Copy link
Collaborator

@gsketefian gsketefian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have that minor issue regarding

at the grid point in equation --> at the grid point in *question*

but otherwise looks good. Approving.

@MichaelLueken
Copy link
Collaborator

Thank you @JeffBeck-NOAA, @gsketefian, and @mkavulich for reviewing and working with @gspetro-NOAA on these updates! Moving forward with merging this PR now.

@MichaelLueken MichaelLueken merged commit fa04c12 into ufs-community:develop Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update develop docs with relevant doc additions from the release branch
6 participants