-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Fix Jenkins Nightly Build #1161
base: develop
Are you sure you want to change the base?
[develop] Fix Jenkins Nightly Build #1161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me!
I was also able to successfully run the skill-score on Orion without issue:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_SUBCONUS_Ind_3km_ics_FV3GFS_lbcs_FV3GFS_suite_WoFS_v0_202411 COMPLETE 58.70
----------------------------------------------------------------------------------------------------
Total COMPLETE 58.70
+ SS_INDEX=0.99963
+ echo 'Skill Score: 0.99963'
Skill Score: 0.99963
+ [[ 0.99963 < 0.700 ]]
+ echo 'Congrats! You pass check!'
Congrats! You pass check!
Approving PR now.
Ran fundamental testing suite on AWS and it passed:
This PR was tested with the Jenkins nightly build for all cloud platforms and they all passed. See result files in the Tests Conducted section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on test results and summary provided.
DESCRIPTION OF CHANGES:
The Jenkins nightly builds have been inconsistent or not working at all on the parallel works (PW) platforms. Some of the issues have been related to the instance's infrastructure on Azure or a conda conflict between the host machine and the conda built by the SRW App (originally seeing on GCP is now being observed for all PW platforms). This PR resolves the conda conflict by deactivating the host conda before activating the
srw_app
environment for all PW platforms. The solution for Azure requires configurations changes, which were done on the backend, but the solution can lead to increased runtimes for some task since the file system and controller node reside in Zone 1 while the compute node can be launched in any zone. Most tasks run just fine with the exception of therun_post
task, which is addressed by increasing the wall time for the skill score/vx test we use for the nightly build. Lastly, removed unneeded old Azure spack-stack logic since we updated to a newer spack-stack build.EDIT: removed the increase in the
run_post
task since it passed with Jenkins on Azure without it.Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):