-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Updating ConfigWorkflow.rst file to reflect changes to Config defaults #1157
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these changes into the ConfigWorkflow.rst
file! The Doc Tests
GitHub Action test is failing due to the title underline being too short on line 18. Please increase the size of the underline as appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the modification to allow the Doc Tests
to successfully pass!
Approving now.
Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
@@ -360,6 +360,9 @@ Set File Name Parameters | |||
``AQM_RC_TMPL_FN``: (Default: "aqm.rc") | |||
Template file name of resource file for NOAA Air Quality Model (AQM). | |||
|
|||
``FIRE_NML_FN_``: (Default: "namelist.fire") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``FIRE_NML_FN_``: (Default: "namelist.fire") | |
``FIRE_NML_FN``: (Default: "namelist.fire") |
@@ -411,6 +416,9 @@ This section contains files and paths to files that are staged in the experiment | |||
``FV3_NML_STOCH_FP``: (Default: ``'{{ [EXPTDIR, [FV3_NML_FN, "_stoch"]|join ]|path_join }}'``) | |||
Path to a namelist file that includes stochastic physics namelist parameters. | |||
|
|||
``FIRE_NML_FP``: (Default: ``'{{ [EXPTDIR, FIRE_NML_FN]|path_join }}'``) | |||
Path to the ``FIRE_NML_FP`` in the experiment directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Path to the ``FIRE_NML_FP`` in the experiment directory. | |
Path to the ``FIRE_NML_FN`` file in the experiment directory. |
@@ -390,6 +393,8 @@ Set File Path Parameters | |||
``AQM_RC_TMPL_FP``: (Default: ``'{{ [user.PARMdir, AQM_RC_TMPL_FN]|path_join }}'``) | |||
Path to the ``AQM_RC_TMPL_FN`` file. | |||
|
|||
``FIRE_NML_BASE_FP``: (Default: ``'{{ [user.PARMdir, FIRE_NML_FN]|path_join }}'``) | |||
Path to the ``FIRE_NML_BASE_FP`` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Path to the ``FIRE_NML_BASE_FP`` file. | |
Path to the ``FIRE_NML_FN`` file in the ``parm`` directory. |
In the RST, |
DESCRIPTION OF CHANGES:
Updated ConfigWorkflow.rst to reflect recent changes to config_defaults.yaml in order to keep documentation up to date.
Type of change
[X ] This change requires a documentation update
TESTS CONDUCTED:
None required for documentation. The docs build successfully on my fork and can be viewed at: https://ufs-srweather-app-joshua-kublnick.readthedocs.io/en/text-us-404/
DEPENDENCIES:
N/A
DOCUMENTATION:
All documentation
ISSUE:
Issue #1132
CHECKLIST
[X ] My code follows the style guidelines in the Contributor's Guide
[X ] I have performed a self-review of my own code using the Code Reviewer's Guide
I have commented my code, particularly in hard-to-understand areas
[X ] My changes need updates to the documentation. I have made corresponding changes to the documentation
My changes do not require updates to the documentation (explain).
[X ] My changes generate no new warnings
New and existing tests pass with my changes
[ X] Any dependent changes have been merged and published
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
[X ] documentation