Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[production/RRFS.v1] fix zero cloud fraction for RRFS ensemble members #186

Conversation

JiliDong-NOAA
Copy link

@JiliDong-NOAA JiliDong-NOAA commented Mar 13, 2024

This PR will address zero cloud fraction issue for RRFS ensemble members using GFS PBL and G-F convection by adding SGS cloud to ccpp SDF and changing conv_cf_opt to Xu-Randall for convective cloud fraction computation for those members.

The change to ccpp-physics is to add conv_cf_opt as an input namelist parameter for runtime switch (conv_cf_opt=1 for GFS PBL members).

ccpp-physics issue:
#185

Several tests for a single case (init 2023/05/10/06Z) have been performed by:

  1. using progcld_thompson_wsm6 in radiation_clouds.f
  2. using sgscloud_radpre with CB
  3. using sgscloud_radpre with XR

Here are total/low/medium/high cloud fractions and downward short wave radiation flux at surface:
cldfra_comparison_f24.pptx
cldfra_comparison_f36.pptx
dswrfsfc.pptx

@JiliDong-NOAA JiliDong-NOAA changed the title change conv_cf_opt to input namelist parameter [production/RRFS.v1] fix zero cloud fraction for RRFS ensemble members Mar 13, 2024
@JiliDong-NOAA
Copy link
Author

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, although do you want to combine this with #180? It would make testing/approval/merge faster.

Copy link
Collaborator

@AnningCheng-NOAA AnningCheng-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine with me.

@JiliDong-NOAA
Copy link
Author

JiliDong-NOAA commented Mar 13, 2024

Approved, although do you want to combine this with #180? It would make testing/approval/merge faster.

sounds good to me. The related FV3 PR is:
NOAA-EMC/fv3atm#801

Copy link
Collaborator

@mzhangw mzhangw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good on its own. It took me some time to understand the difference from xr_cnvcld (flag for using suspended convective clouds in Xu Randall) introduced in PR184.

Copy link
Collaborator

@ericaligo-NOAA ericaligo-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

haiqinli added a commit to haiqinli/ccpp-physics that referenced this pull request Mar 14, 2024
@grantfirl
Copy link
Collaborator

This PR was combined into #180.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants