Added bookmark to edge tests #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrenjaminBanklin
changed the base branch from
dev/32-pigeonite
to
dev/33-serpierite
…to make them more visible. Adding quotes around SCSS urls per stylelint rules.
FrenjaminBanklin
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
We discovered some things in the pursuit of this that I think are worth addressing in another issue, but this looks good considering the single mockup we had to go by.
I did technically contribute to this myself however, so another pair of eyes would be nice.
RachelDau
approved these changes
Sep 21, 2023
|
Yeah, the edges not matching is kind of an acceptable compromise at the moment. This can potentially be fixed/improved in #2111, but it'll do for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added bookmark/dogear excerpt option to the following excerpt styles:
-filled box
-bordered box
-card
-white paper
-modern paper
-light yellow paper
-dark yellow paper
-aged paper