Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instance lock management #1583

Open
clpetersonucf opened this issue May 8, 2024 · 0 comments
Open

Improve instance lock management #1583

clpetersonucf opened this issue May 8, 2024 · 0 comments

Comments

@clpetersonucf
Copy link
Member

Instance lock management is a little screwy right now. Currently:

widget_instance_lock in the v1 API will lock an instance for a given user for two minutes. widget_instance_lock is called once when the creator first initializes, but never again. The cache item associated with the lock method persists for two minutes, which means after two minutes the instance is again considered editable. Additionally, the creator will enter a failure state if trying to edit an instance locked by someone else, but it's not graceful - the error dialog is blank and it can be dismissed without reloading or exiting the page.

Two improvements to this feature could include:

  1. Ensure the widget_instance_lock request is performed on a two-minute interval while someone is on the creator page (easiest solution might be to set the query's staleTime to two minutes).
  2. Improve creator failure state when the lock request returns false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant