Add fx.ShutdownError option #996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
abramlab
force-pushed
the
shutdown-error-option
branch
from
2c9632c
to
02a2658
Compare
abramlab
force-pushed
the
shutdown-error-option
branch
from
02a2658
to
9f07316
Compare
abramlab
force-pushed
the
shutdown-error-option
branch
from
6d09401
to
8b1500d
Compare
Codecov Report
@@ Coverage Diff @@
## master #996 +/- ##
==========================================
- Coverage 98.09% 98.04% -0.05%
==========================================
Files 39 39
Lines 1995 1996 +1
==========================================
Hits 1957 1957
- Misses 30 31 +1
Partials 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abramlab
force-pushed
the
shutdown-error-option
branch
3 times, most recently
from
4d26279
to
0778cf0
Compare
abramlab
force-pushed
the
shutdown-error-option
branch
from
0778cf0
to
a29986d
Compare
|
@jasonmills what else is needed to merge the pull request? |
abramlab
force-pushed
the
shutdown-error-option
branch
2 times, most recently
from
3357fdf
to
c7021c1
Compare
abramlab
force-pushed
the
shutdown-error-option
branch
from
c7021c1
to
bbd8c2a
Compare
abramlab
force-pushed
the
shutdown-error-option
branch
from
bbd8c2a
to
a285dde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the fx.ShutdownError option, to be able to pass a custom error to Shutdowner and retrieve it from the application as the reason it shutdown.
Refers #672