Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on invalid lifecycle hooks #1090

Open
sywhang opened this issue Jun 1, 2023 · 0 comments
Open

Error on invalid lifecycle hooks #1090

sywhang opened this issue Jun 1, 2023 · 0 comments
Labels
enhancement

Comments

@sywhang
Copy link
Contributor

sywhang commented Jun 1, 2023

Lifecycle hooks cannot take a dependency on things that the constructor does not have a direct dependency on or produces as a result type.

When a user mistakenly specifies a hook that does this, it will fail with dependency not satisfied error which can be confusing. We should detect this at Provide time and return an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sywhang