Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Bootstrap 5 #533

Open
ConnorSheremeta opened this issue Jan 19, 2024 · 0 comments
Open

Migrate to Bootstrap 5 #533

ConnorSheremeta opened this issue Jan 19, 2024 · 0 comments

Comments

@ConnorSheremeta
Copy link
Contributor

The project now gives the ability to migrate pages over to Bootstrap 5 following the completion and deployment (version tag: 1.9.4) of this work: #524

Summary of the use of different versions of Bootstrap 5 in library-cms:

  • We import bootstrap 3.3.2 in app/webpacker/src/javascripts/bootstrap.min.js which I believe is not used

  • We use bootstrap 4.1.1 in /admin, which is not public facing of course

  • Bootstrap 4.3.1 is used in /support which is referenced here:

    <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css" integrity="sha384-ggOyR0iXCbMQv3Xipma34MD+dH/1fQ784/j6cY/iJTQUOhcWr7x9JvoRxT2MZw1T" crossorigin="anonymous">

  • Bootstrap 4.6.2 is used on most public-facing pages... all other active public-facing pages not listed above

When we start to migrate to Bootstrap 5 using the new app-level layout called 2020_bootstrap_v5 those pages will then be on Bootstrap 5.3.2. Once migrated fully off of each version, clean-up will likely be needed in the codebase surrounding old bootstrap references.

Bootstrap 5 dropped jQuery in favor of vanilla javascript. The bootstrap 5.3.2 app-level layout called 2020_bootstrap_v5 supports jQuery to assist in migrating over, allowing migrating to Bootstrap 5/vanilla javascript in stages.

Once we no longer rely on jQuery on all pages that use and will use Bootstrap 5 the import of jQuery can be removed which is here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant