Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible discussion topic: Combined PySEP + MTUQ workflow #258

Open
rmodrak opened this issue Mar 22, 2024 · 2 comments
Open

Possible discussion topic: Combined PySEP + MTUQ workflow #258

rmodrak opened this issue Mar 22, 2024 · 2 comments

Comments

@rmodrak
Copy link
Member

rmodrak commented Mar 22, 2024

An approach for generating event-specific MTUQ scripts from PySEP config files:

https://github.com/rmodrak/mtuq_script_generator/blob/3e2181639da4615822e5610c077a06d19827288c/mtuq_script_generator.py#L110

Generating event-specific MTUQ scripts in this way can help avoid some tedious copying and pasting. Also, could be helpful as UAF seeks a reproducible, standardized workflow?

@bch0w
Copy link
Member

bch0w commented Mar 22, 2024

Hi @rmodrak, this looks like a great idea. Let me know if you need anything on the PySEP end.

One thing I'll note is that since the scope of PySEP has broadened, the current, default PySEP settings do not create the requisite MTUQ files, so a user would have to know which flags to turn on to get the required weights files, and output with a file naming format that MTUQ can parse.

Perhaps adding a flag, e.g., pysep ./config.yaml --mtuq_ready (or similar naming) could help standardize things for MTUQ input, and would be useful for MTUQ users?

Some relevant PySEP issues for reference: adjtomo/pysep#118, adjtomo/pysep#125, adjtomo/pysep#129

@rmodrak
Copy link
Member Author

rmodrak commented Mar 23, 2024

Thanks for these comments and linked issues, much appreciated. Any flags or options that support Carl's way or working could be helpful.

UAF could perhaps develop its own templates, or even its own generator based on the above? I will try to remember to bring up over Zoom...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants