fix: dataImport task should not run tomcatClean and tomcatDeploy tasks

[jgribonvald]

Checklist

• the individual contributor license agreement is signed
• commit message follows commit guidelines
• tests are included
• documentation is changed or added
• message properties have been updated with new phrases
• view conforms with WCAG 2.0 AA

Description of change

This permit to avoid to undeploy and deploy apps when only a dataImport is run

Should solve issue #252

[ChristianMurphy]

@jgribonvald I'm cautious about making the logic of the task aware of another task.
Leveraging mustRunAfter or shouldRunAfter (https://docs.gradle.org/current/dsl/org.gradle.api.Task.html) here https://github.com/Jasig/uPortal-start/blob/1c56e3ed586b750e91a75b10d951c51292394347/buildSrc/src/main/groovy/org/apereo/portal/start/gradle/plugins/GradleImportExportPlugin.groovy#L20 may be a better approach.

[ChristianMurphy]

Also note #252 (comment)

[jgribonvald]

@ChristianMurphy modifying the dependOn or running before the deploy won't help and I'm not sure that you understood the problem and my change, so let me trying explaining the problem, or tell me what is wrong on my change :

When I want to update a portlet-definition (at any moment during the day) from a file I run the target ./gradlew :overlays:uPortal:dataImport -Dfile=/PATH/TO/FILE/my.portlet-definition.xml.
So only for a such change you will clean the project and deploy the portal whereas it is already deployed and running on the same version. More in production if you don't disable the context refresh on the tomcat (that is the default purposed conf in uPortal-start) it will get out all users and relaunch the uPortal context (so the service will be unavailable few minutes).

My change only disable tomcatClean and tomcatDeploy when you run as primary/main/initial command the dataImport target but not on other uPortal task which have the dataImport task as dependency.

[ChristianMurphy]

My change only disable tomcatClean and tomcatDeploy when you run as primary/main/initial command the dataImport target but not on other uPortal task which have the dataImport task as dependency.

Exactly, so the tomcat tasks are not depended on by dataInit.
So the dependsOn relationship should be represented in a different task.
Only a shouldRunAfter is needed to ensure the task will appear in the correct order in the task graph.

[jgribonvald]

@ChristianMurphy so for you if we replace dependsOn project.rootProject.tasks.portalProperties, project.tasks.tomcatDeploy by something like

dependsOn project.rootProject.tasks.portalProperties
mustRunAfter project.tasks.tomcatDeploy

this will have the same effect ? I'm sorry I don't know a lot of gradle...

[jgribonvald]

@ChristianMurphy: Ok I've tested and rewrote my PR on this way, it's really better. Thanks to show me the right way 👼

On an other side do you think that other tasks dataExport, dataDelete, dataList should benefit of a such change or not ? I think that they should expect maybe dataList.

[jgribonvald]

I've pushed one commit per task change like that you will be able to make your choice 😉

[bjagg]

👍