-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataImport task run tomcatDeploy without compiled custom skins #252
Comments
this could be a problem on production (with provided conf) because if you import a portlet definition it will redeploy your tomcat and if you autorized tomcat autoDeploy the service won't be available during the task run and until the project is mounted back ! <Host ... unpackWARs="false" autoDeploy="false"...c> and I defined all |
This permit to avoid to undeploy and deploy apps when only a dataImport is run Should solve issue uPortal-Project#252
Folks -- the Perhaps they shouldn't require |
@drewwills I don't understand the requirement, could you explain the case on where the version deployment of uPortal is required ? My case fix #281 fix the problem of runing only a dataImport to apply few change on production (as example setting new options on a portlet definition). In the current use (without my fix) dataImport can cause a service failure during the redeploy, as many peoples will run it on the same server where the portal is deployed. In my mind we should always make a tomcatDeploy when changing uPortal version or any other dependency before to run a dataImport, but nothing avoid to run dataImport on a separate command... |
This permit to avoid to undeploy and deploy apps when only a dataImport is run Should solve issue uPortal-Project#252
Describe the bug
#227 removed CompileLess but without removing tomcatDeploy. So the tomcatDeploy remove and doesn't deploy local/custom used skins and it break the deployed app (the portal serve page without skin)
To Reproduce
Steps to reproduce the behavior:
:overlays:uPortal:tomcatClean
and:overlays:uPortal:tomcatDeploy
Expected behavior
dataImport should not run
:overlays:uPortal:tomcatClean
and:overlays:uPortal:tomcatDeploy
or remove #227 commitsThe text was updated successfully, but these errors were encountered: