Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataImport task run tomcatDeploy without compiled custom skins #252

Open
jgribonvald opened this issue Dec 7, 2018 · 3 comments
Open

dataImport task run tomcatDeploy without compiled custom skins #252

jgribonvald opened this issue Dec 7, 2018 · 3 comments
Labels

Comments

@jgribonvald
Copy link
Contributor

Describe the bug
#227 removed CompileLess but without removing tomcatDeploy. So the tomcatDeploy remove and doesn't deploy local/custom used skins and it break the deployed app (the portal serve page without skin)

To Reproduce
Steps to reproduce the behavior:

  1. have or create a local skin, deploy and use it (run tomcat)
  2. if you do a dataImport it will run :overlays:uPortal:tomcatClean and :overlays:uPortal:tomcatDeploy
  3. go back to your portal and refresh the page
  4. See error - there isn't more a skin applied - the skin is missing from sources !

Expected behavior
dataImport should not run :overlays:uPortal:tomcatClean and :overlays:uPortal:tomcatDeploy or remove #227 commits

@jgribonvald jgribonvald added the bug label Dec 7, 2018
@jgribonvald
Copy link
Contributor Author

this could be a problem on production (with provided conf) because if you import a portlet definition it will redeploy your tomcat and if you autorized tomcat autoDeploy the service won't be available during the task run and until the project is mounted back !
I don't encounter the problem as I set

<Host ... unpackWARs="false" autoDeploy="false"...c>

and I defined all <Context ... for all autorized apps

jgribonvald added a commit to GIP-RECIA/uPortal-start that referenced this issue Feb 26, 2019
This permit to avoid to undeploy and deploy apps when only a dataImport is run
Should solve issue uPortal-Project#252
@drewwills
Copy link
Contributor

Folks -- the dataImport (and other Import/Export tasks) require tomcatDeploy because they use the deployed versions of uPortal technology to run.

Perhaps they shouldn't require tomcatClean.

@jgribonvald
Copy link
Contributor Author

@drewwills I don't understand the requirement, could you explain the case on where the version deployment of uPortal is required ?

My case fix #281 fix the problem of runing only a dataImport to apply few change on production (as example setting new options on a portlet definition). In the current use (without my fix) dataImport can cause a service failure during the redeploy, as many peoples will run it on the same server where the portal is deployed.

In my mind we should always make a tomcatDeploy when changing uPortal version or any other dependency before to run a dataImport, but nothing avoid to run dataImport on a separate command...

jgribonvald added a commit to GIP-RECIA/uPortal-start that referenced this issue Apr 5, 2019
This permit to avoid to undeploy and deploy apps when only a dataImport is run
Should solve issue uPortal-Project#252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants