Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix list component to call apiUrl as background task #91

Open
bjagg opened this issue Aug 9, 2019 · 0 comments · May be fixed by #119
Open

Fix list component to call apiUrl as background task #91

bjagg opened this issue Aug 9, 2019 · 0 comments · May be fixed by #119
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bjagg
Copy link
Member

bjagg commented Aug 9, 2019

The NotificationAction apiUrl attribute holds the internal API call that was meant to be called with fetch rather than a submit from web components. Some actions do require a submit to follow redirects. This is now supported with a new boolean attribute redirect.

  • icon: does not present actions
  • modal: has already been updated to support this approach
  • banner: ???
  • list: should adopt the modal approach
@bjagg bjagg added bug Something isn't working good first issue Good for newcomers labels Aug 9, 2019
@jonathanmtran jonathanmtran linked a pull request Oct 2, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@bjagg