Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non null-safe assignment when dealing with wildcards #6881

Open
theosotr opened this issue Oct 30, 2024 · 0 comments
Open

Non null-safe assignment when dealing with wildcards #6881

theosotr opened this issue Oct 30, 2024 · 0 comments

Comments

@theosotr
Copy link

Command

javac -J--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
  -J--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
  -J--add-opens=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED \
-processor org.checkerframework.checker.nullness.NullnessChecker \
-cp checker-framework/checker/dist/checker.jar -Aignorejdkastub Test.java

File

import java.util.*;
import org.checkerframework.checker.nullness.qual.*;

public class Test {

  static public void main(String[] args) {
      List<List<? extends Number>> lists = new ArrayList<>();
      List<? super List<? extends Number>> y = lists;
      // This assignment is not null-safe
      List<? super @Nullable List<? extends Number>> x = y;
      x.add(null);
      lists.get(0).toString();
  }
}

Actual behavior

The code passes the checks of the checker, but there's NPE

Exception in thread "main" java.lang.NullPointerException: Cannot invoke "Object.toString()" because the return value of "java.util.List.get(int)" is null
        at Test.main(Test.java:12)

Expected behavior

The assignment List<? super @Nullable List<? extends Number>> x = y; should have been rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants