Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beginner session and scala3 codec doc #791

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Quafadas
Copy link

@Quafadas Quafadas commented Feb 1, 2023

I wrote out the documentation, which I believe may have helped me to get Skunk in the right place in my own programs.

This may be undesirable for several reasons.

  • It may not be best practice - I'm not a confident user of skunk,
  • It may be both too specific (an http4s app)
  • As well as too broad - should skunk docs concern themselves with helping with app design?

What I'm saying is that I would not be offended, if this documentation PR was not merged - but at least I tried to contribute my learning back.

@GitsMcGee
Copy link

This documentation would have helped me when I first got started, so thank you!

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #791 (21e9c27) into main (f826178) will not change coverage.
The diff coverage is n/a.

❗ Current head 21e9c27 differs from pull request most recent head d59c957. Consider uploading reports for the commit d59c957 to get more accurate results

@@           Coverage Diff           @@
##             main     #791   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files         126      126           
  Lines        1719     1719           
  Branches      117      117           
=======================================
  Hits         1460     1460           
  Misses        259      259           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Quafadas Quafadas changed the title WIP: Add beginner session and scala3 codec doc Add beginner session and scala3 codec doc Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants