Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of Rust crates can sometimes cause linker errors when building plugin #2

Open
tychedelia opened this issue Nov 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@tychedelia
Copy link
Owner

If a Rust crate links against system deps or otherwise symbols that aren't included in our final C++ build, we'll get errors. This is easy to do for anything that includes a hiddden *-sys crate somewhere in its deps. We should provide a way to specify platform specific extra lib deps to be linked during our build, likely adding some fields to the td-rs.metadata Cargo.toml field. Unfortunately, this is a bit harder to handle in a generic way on macOS, since the xcode file format requires messing with XML data. On windows, we can just include additional build params that specify extra paths and lib names.

@tychedelia tychedelia added the enhancement New feature or request label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant