Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java library should not use singletons #650

Open
chrylis opened this issue Oct 1, 2021 · 2 comments
Open

Java library should not use singletons #650

chrylis opened this issue Oct 1, 2021 · 2 comments
Labels
status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap

Comments

@chrylis
Copy link

chrylis commented Oct 1, 2021

As a followup to #430, while using global setup such as Twilio.init is ordinary practice in some languages, it is contrary to Java standard practices and substantially interferes in standard Java application architectures.

For version 9 development, your customers would be much better served by following the standard layout of a service interface TwilioApi and a class Twilio implements TwilioApi; this would not impose any more significant burden on consumers (just new Twilio(username, password) instead of Twilio.init(username, password)) but would dramatically enhance testability and some production use cases such as multitenant implementations.

@JenniferMah JenniferMah added status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap labels Oct 8, 2021
@JenniferMah
Copy link
Contributor

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

@joakim-olsson
Copy link

joakim-olsson commented Mar 1, 2022

My group and I would like to attempt this issue as a part of our uni course, could someone assign me to the issue?
Thanks!

edit: PR up, see below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants