-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use string concatenation on _serializedATN in generated lexer file #379
Comments
The issue is not actual since ANTLR 4.10. It's
It's not frendly for text editors since generated string is very long. |
It's a binary encoding in string form. I'm not sure it's meant to be friendly :) |
But if you turn on "word wrap", the file will look weird. |
how so? |
@KvanTTT I only see 4.6.6 on Nuget. Is there another way to get 4.10+? |
Like the following. Too much different line heights:
Unfortunately not. It's a fork of the official repository. I can only advise you to use either official JavaScript target or wait for the official support of TypeScript. Also, you can try to ask @sharwell to update the fork. |
I don't see any issue with that. |
You should migrate to the new packages and newer ANTLR versions as #381 |
In a very large token file, the generated lexer file contains a lot of string concatenations in the _serializedATN string. This causes Visual Studio and MS Build to crash with a StackOverflowException (as reported and to be fixed here: dotnet/runtime#76953).
Is it possible to use one long string instead of a long list of string concatenations? Any other options or ideas?
Repro Visual Studio solution containing the generated token file can be found here: dotnet/runtime#76953 (comment).
The text was updated successfully, but these errors were encountered: