Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Configurable function for ending / relinquishing processUntilTime #6

Open
tungs opened this issue Jun 22, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@tungs
Copy link
Owner

tungs commented Jun 22, 2021

Is your feature request related to a problem? Please describe.
Currently when timeweb goes to a certain virtual time, it creates a blocking loop (see processUntilTime). This can create performance issues and poor user experience when run inside a browser.

Additionally, the user may want to stop iterating based off of some logic of dynamic page conditions. In this case, they would want to be able to exit the blocking loop too (see tungs/timesnap#63 for an example).

Describe the solution you'd like
It would be nice to be able to set some sort of condition to either relinquish that loop, either based on real time (so as not to freeze the browser), or some user defined criteria.

It would be good to be able to pass a custom function that serves as a condition to end the blocking loop in processUntilTime. It'd be good if the user could distinguish between relinquishing (where the loop is returned to), versus ending.

Describe alternatives you've considered
This could be another function besides goTo, like relinquishingGoTo.

Additional context
Note that some of the capturing of screenshots relies on the blocking nature of timeweb (for instance WebGL canvases can become stale if not captured immediately after rendering). This should be considered when implementing this feature.

@tungs tungs added the enhancement New feature or request label Jun 22, 2021
@tungs tungs self-assigned this Jun 22, 2021
@tungs tungs changed the title [FEATURE REQUEST] [FEATURE REQUEST] Configurable function for ending / relinquishing processUntilTime Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant